i found the BUG (unaproved news shown for Gests)

[samiro]

the problem: the articles that saved as "unapproved" or "saved as draft" showen to gust...
the bug: when including the code - to view more than 1 category. The problem papers...

When including the articles like this:

Code: Select all

<?PHP
$number= '10';
$static = 'true';
$category = '1';
$template = 'Header';
include("/hsphere/local/home/samiro/bwoman.co.il/articles/news/show_news.php");
?>

everything work fine

But when include the code like this:

Code: Select all

<?PHP
$number= '10';
$static = 'true';
$category = '1,2,3,4,5,6,9';
$template = 'Header';
include("/hsphere/local/home/samiro/bwoman.co.il/articles/news/show_news.php");
?>

the problem appears... if the article published in one of these categories (2,3,4,5,6,9) not (1) and everyone (even gusts) can see the article even if it saved as "unapproved" or "saved as draft"

HELPPPPP

what can I do to fix it?

[samiro]

pleaseeeeeeeeeeeee

[mark99]

Can confirm this as a bug, not sure how to fix though, hope somebody else has an idea.

[Chaser]

open inc/show.news.php and replace

Code: Select all

   if ($allow_categories[0] != ''){

with this

Code: Select all

   if ($allow_categories[0] != '' and $hidden = 0){

[Ramon]

That won't ever work...

I think you mean

Code: Select all

      if ($allow_categories[0] != '' and $hidden == 0){

[DarkSlim]

If anyone can check the fix and confirm that it is working
I'll add this fix to the Index

[D72]

That won't ever work...

I think you mean

Code: Select all

      if ($allow_categories[0] != '' and $hidden == 0){

Hey man, you're back!?
Just for fun or for some reasons?
Gelukkig nieuwjaar kerel!

[Chaser]

That won't ever work...

I think you mean

Code: Select all

      if ($allow_categories[0] != '' and $hidden == 0){

No, it's tested and works. Yours doesn't work.

I think you mean

Code: Select all

      if ($allow_categories[0] != '' and $hidden == '0'){

[samiro]

so
witch one we need to try ?!

edit:
i try them all.. this one:
if ($allow_categories[0] != '' and $hidden == '0'){

show also news that are without category

[samiro]

maybe this one make the bug ?
http://forums.cutenewsru.com/viewtopic. ... aklocation

[Chaser]

maybe this one make the bug ?
http://forums.cutenewsru.com/viewtopic. ... aklocation

No, i don't think so. This function is for smilies.

[samiro]

open inc/show.news.php and replace

Code: Select all

   if ($allow_categories[0] != ''){

with this

Code: Select all

   if ($allow_categories[0] != '' and $hidden = 0){

OMG
THANK YOUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU

[samiro]

Sorry - my mistake
Although this is the bug fix
But did new bug
Suddenly, the script ignores the categories - it displays Latest News - No matter what value there is in the category...

($ category = '2 ') or ($ category = '3 ') or ($ category = '2,4,5,6 ')
it dosnt matter - it just display Latest News...

[samiro]

here is the bug fix
http://forums.cutenewsru.com/problem-wi ... html#18083

[DarkSlim]

I don't know if it will help but instead of:

Code: Select all

if ($allow_categories[0] != ''){
      foreach ($allow_categories as $k => $v){
         for ($i = 0; $i < 10; $i++){
            if (!in_array($v.$i, $allow_categories)){
               $where[] = 'and';
               $where[] = 'category !~ %'.$v.$i.'%';
            }

            if (!in_array($i.$v, $allow_categories)){
               $where[] = 'and';
               $where[] = 'category !~ %'.$i.$v.'%';
            }
         }
      }

I'm using:

Code: Select all

if (reset($allow_categories)){
      $where[] = 'and';
      $where[] = 'category =~ %'.(count($allow_categories) > 1 ? '['.join('|', $allow_categories).']' : join('', $allow_categories)).'%';

      foreach ($allow_categories as $k => $v){
         for ($i = 0; $i < 10; $i++){
            if (!in_array($v.$i, $allow_categories)){
               $where[] = 'and';
               $where[] = 'category !~ %'.$v.$i.'%';
            }

            if (!in_array($i.$v, $allow_categories)){
               $where[] = 'and';
               $where[] = 'category !~ %'.$i.$v.'%';
            }
         }
      }

and another thing, in the begining of the file instead of:

Code: Select all

if (!$is_logged_in or ($is_logged_in and $member['level'] > 2)){
      ...
   }

* the three points (...) are for that code that's between the brackets (don't sure what was there in the original)

I'm using just:

Code: Select all

$where[] = 'hidden = 0';
      $where[] = 'and';

(Without the if)

If it still won't work for you there's another place, I just don't remember 100% where it was
and what's the original code to replace but I think it start like that:

Code: Select all

foreach($allow_categories as $single_cat){
         $where[] = 'category =~ %'.$single_cat.'%';
                    ....

Add:

Code: Select all

$where[] = 'and';
$where[] = 'hidden = 0';